Hi,

I'm just running the code gen template c# Master Generated and noticed that even if a column is not Nullable, a Nullable property is generated.
Is this correct?

Cheers,

John

Just to register my vote, when I have a table with required primitive fields, so I know there'll always be a value there, having to constantly cast or .Value the member is a real pain.  Seems intuitive to me that if the DB field is not nullable, then the member should not be nullable.  Intellisense will show you immediately if the member is nullable or not, so the programmer does not need to know anything about the DB schema before hand.

 It should at least be an option in the code gen.  You can always default it to everything nullable for backwards compatibility/convention.

 Thanks,

John K.

 

I also vote for having EntitySpaces not generate nullable properties if the db field is not nullable.

 Steve O.

Thank you,

I tested it in my little test project, and it works the way I wanted it to work.

Steve

Just tested it with the newest maintenance release (with the last MyGeneration release) and for me it does not work as expected.

I have a table (T_Validator) in Oracle 10g

ID         Number 15,0 primary key
IsValid   Number 1,0 non-nullable

The generated proxy stub looks like

        public System.Decimal Id
        {
            get
            {
                if (this.Entity.es.IsDeleted)
                    return (System.Decimal)this.Entity.
                        GetOriginalColumnValue(TValidatorMetadata.ColumnNames.Id);
                else
                    return this.Entity.Id;
            }
            set { this.Entity.Id = value; }
        }

        public System.Decimal IsValid
        {
            get
            {
               
                if (this.IncludeColumn(TValidatorMetadata.ColumnNames.IsValid))
                    return this.Entity.IsValid;
                else
                    return null;
            }
            set { this.Entity.IsValid= value; }
        }

Hi Robert

The code you've posted above (from the proxy class) isn't anything to do with setting the property - whether it's to null or not.  Basically you have a choice as to whether you want to include a property or not in the proxy (i.e. you might only want the proxy/xml to include chaged properties instead of all properties) - the check (and return of null) looks to see if this field/property should be included in the proxy being returned - if so, it returns it, if it shouldn't be included, it returns null - does that make sense?

Cheers

Martin

Hi Martin,

the problem is that the generated code isn't even compilable.

Let's have a look again:

1    public System.Decimal IsValid
2        {
3            get
4            {
5                if (this.IncludeColumn(TValidatorMetadata.ColumnNames.IsValid))
6                    return this.Entity.IsValid;
7                else
8                    return null;
9            }
10           set { this.Entity.IsValid= value; }
11       }

IsValid is a non-nullable property of type System.Decimal. But in line 8 (the null-assignment) the return value is not compatible with the type definition of the property.

Since this is auto-generated code something seems to be not correct...

Mike.Griffin:

This is a little confusing because you hi-jacked an existing thread (frowned upon ) and it wasn't even really related.

Isn't it really?

Since this thread was already hijacked in February w/o any comment from you I thought this was ok. Anyway, next time I will open new threads.

However, when you generated your classes did you check the special flag in the Settings template concerning nullable fields?

Yes, of course. See, if I do not check the special flag the code generated is as following (and works - but in the database table the field is non-nullable):

 Code:

public System.Decimal? IsValid
{
    get
    {
        if (this.IncludeColumn(TValidatorMetadata.ColumnNames.IsValid))
            return this.Entity.IsValid;
        else
            return null;
    }
    set { this.Entity.IsValid= value; }
}

With the flag checked the generated code is not compilable:

public System.Decimal IsValid
{
    get
    {
        if (this.IncludeColumn(TValidatorMetadata.ColumnNames.IsValid))
            return this.Entity.IsValid;
        else
            return null;
    }
    set { this.Entity.IsValid= value; }
}

Hi

I think what would need to happen here is that the "Generated - ProxyStub - (C#).cst" templates need changing around the property setter to see whether the user has chosen the "UseNullableTypesAlways" setting - if so then write output as it does currently, if not then just skip the "if (this.IncludeColumn(.....)" test and just return the property regardless - shouldn't take much in the way of changes to the template to be honest, not from what I can see at first glance anyway

Hope that helps

Martin

Hi Martin,

thanks for your reply. I'm a new user of EntitySpaces (since a week) and therefore not that deeply involved. I'll see if I can dig into modifying the template...

Thanks again!

Thanx Robert (and Martin). When we added the "Use Nullable Types Always" flag it was kind of experimental. The proxy templates have not been updated to account for that feature. I will bump this up on our list for our next maintenance release. We used to have a big warning on the "Use Nullable Types Always" flag but looks like we removed it. As an FYI, proxies are key to ES2009 and will be receiving much attention. We will bump this in our priority.

In the meantime Robert, if you need any help on altering the templates until the official fix/alteration is in then post up which templates you're using (MyGen or CodeSmith) and I'm sure either myself or one of the EntitySpaces team can help in making the correction

Cheers

Martin